diff --git a/backend_dnpds40.c b/backend_dnpds40.c index c56444b..560ff69 100644 --- a/backend_dnpds40.c +++ b/backend_dnpds40.c @@ -229,7 +229,7 @@ static struct dnpds40_printjob *combine_jobs(const struct dnpds40_printjob *job1 #if 0 // XXX TODO: 2x6*2 + 2x6*2 --> 8x6+cutter! - // problem is that 8x6" size is 4 rows smaller than 2* 4x6" prints, posing a problem. + // problem is that 8x6" size is 4 rows smaller than 2* 4x6" prints, posing a problem. Maybe cut off the top and bottom 2 rows? /* Only handle cutter if it's for 2x6" strips */ if (job1->cutter != 0 && job1->cutter != 120) @@ -1960,7 +1960,6 @@ top: goto top; case 900: INFO("Waking printer up from standby...\n"); - // XXX do someting here? break; case 1000: /* Cover open */ case 1010: /* No Scrap Box */ @@ -2022,7 +2021,7 @@ top: dnpds40_cleanup_string((char*)resp, len); -#if 0 // XXX Fix 600dpi support on CW01 +#if 0 // TODO Fix 600dpi support on CW01 // have to read the last DPI, and send the correct CWD over? if (ctx->dpi == 600 && strcmp("RV0334", *char*)resp) { ERROR("600DPI prints not yet supported, need 600DPI CWD load\n"); diff --git a/backend_hiti.c b/backend_hiti.c index e430413..7678ed6 100644 --- a/backend_hiti.c +++ b/backend_hiti.c @@ -2100,6 +2100,7 @@ struct dyesub_backend hiti_backend = { /* TODO: - Figure out 5x6, 6x5, and 6x6 prints (need 6x8 or 6x9 media!) + - Confirm 6x2" print dimensions (windows?) - Confirm 5" media works properly - Figure out stats/counters for non-4x6 sizes - Job status & control (QJC, RSJ, QQA) diff --git a/backend_kodak605.c b/backend_kodak605.c index 0fb9e4e..f787dea 100644 --- a/backend_kodak605.c +++ b/backend_kodak605.c @@ -79,7 +79,7 @@ struct kodak605_status { uint16_t b4_complete; uint16_t b4_total; uint8_t b4_sts; /* see BANK_STATUS_* */ -/*@70*/ uint8_t unk[4]; /* XXX EK605 has 01/00/00/00, EK7000 has 01/01/01/01 */ +/*@70*/ uint8_t unk[4]; /* EK605 has 01/00/00/00, EK7000 has 01/01/01/01 */ /*@74*/ uint8_t null_2[2]; /* 00 00 */ /*@76*/ uint8_t null_3[1]; /* EK7000 only */ } __attribute__((packed)); @@ -552,7 +552,7 @@ static int kodak605_main_loop(void *vctx, const void *vjob) { return ret; } offset += 44; - // XXX sanity check backpriny parameters.. + // XXX sanity check backprint parameters.. } /* Send print job */ diff --git a/backend_kodak6800.c b/backend_kodak6800.c index dbc4835..20f7572 100644 --- a/backend_kodak6800.c +++ b/backend_kodak6800.c @@ -602,13 +602,6 @@ static int kodak6850_send_unk(struct kodak6800_ctx *ctx) return CUPS_BACKEND_FAILED; } -#if 0 - // XXX No particular idea what this actually is - if (rdbuf[1] != 0x01 && rdbuf[1] != 0x00) { - ERROR("Unexpected status code (0x%02x)!\n", rdbuf[1]); - return CUPS_BACKEND_FAILED; - } -#endif return ret; } diff --git a/backend_mitsu70x.c b/backend_mitsu70x.c index e68557d..7553357 100644 --- a/backend_mitsu70x.c +++ b/backend_mitsu70x.c @@ -342,7 +342,7 @@ struct mitsu70x_printerstatus_resp { int16_t serno[6]; /* LE, UTF-16 */ struct mitsu70x_status_ver vers[7]; // components are 'MLRTF' uint8_t null[2]; - uint8_t user_serno[6]; /* XXX Supposedly, don't know how to set it */ + uint8_t user_serno[6]; /* XXX Supposedly. Don't know how to set it! */ struct mitsu70x_status_deck lower; struct mitsu70x_status_deck upper; } __attribute__((packed)); @@ -1160,8 +1160,8 @@ repeat: mhdr.hdr[3] = 0x90; } } else if (ctx->type == P_FUJI_ASK300) { - job->laminatefname = CORRTABLE_PATH "/ASK300M2.raw"; // Same as D70 -// job->lutfname = CORRTABLE_PATH "/CPD70L01.lut"; // XXX guess, driver did not come with external LUT! + job->laminatefname = CORRTABLE_PATH "/ASK300M2.raw"; /* Same as D70 */ + job->lutfname = NULL; /* Printer does not come with external LUT */ if (mhdr.speed == 3 || mhdr.speed == 4) { mhdr.speed = 3; /* Super Fine */ job->cpcfname = CORRTABLE_PATH "/ASK300T3.cpc"; @@ -1718,8 +1718,7 @@ static int mitsu70x_main_loop(void *vctx, const void *vjob) int copies; int deck, legal, reqdeck; - struct mitsu70x_printjob *job = (struct mitsu70x_printjob *) vjob; // XXX not clean. -// const struct mitsu70x_printjob *job = vjob; + struct mitsu70x_printjob *job = (struct mitsu70x_printjob *) vjob; if (!ctx) return CUPS_BACKEND_FAILED; diff --git a/backend_mitsu9550.c b/backend_mitsu9550.c index 76beff1..331b93c 100644 --- a/backend_mitsu9550.c +++ b/backend_mitsu9550.c @@ -1060,7 +1060,8 @@ static int validate_media(int type, int media, int cols, int rows) } break; case P_MITSU_9800: - case P_MITSU_9810: // XXX and don't forget the 9820S + case P_MITSU_9810: +// case P_MITSU_9820S: switch(media & 0xf) { case 0x01: /* 3.5x5 */ if (cols != 1572 && rows != 1076) @@ -1140,8 +1141,7 @@ static int mitsu9550_main_loop(void *vctx, const void *vjob) { int copies = 1; #endif -// const struct mitsu9550_printjob *job = vjob; - struct mitsu9550_printjob *job = (struct mitsu9550_printjob*) vjob; // XXX not good. + struct mitsu9550_printjob *job = (struct mitsu9550_printjob*) vjob; if (!ctx) return CUPS_BACKEND_FAILED; @@ -1151,13 +1151,6 @@ static int mitsu9550_main_loop(void *vctx, const void *vjob) { /* Okay, let's do this thing */ ptr = job->databuf; -#if 0 - /* If hdr2 is not present, we have to generate copies ourselves! */ - if (!job->hdr2_present) - copies = job->copies; - // XXX.. -#endif - /* Do the 98xx processing here */ if (!ctx->is_98xx || job->is_raw) goto bypass; diff --git a/backend_mitsud90.c b/backend_mitsud90.c index 2ff049c..70d8abe 100644 --- a/backend_mitsud90.c +++ b/backend_mitsud90.c @@ -992,8 +992,7 @@ int mitsud90_get_info(struct mitsud90_ctx *ctx) INFO("TYPE_83: %02x\n", resp.x83); INFO("TYPE_84: %02x\n", resp.x84); - /* XXX Dump iSerial, sleep time settings */ - // XXX what about resume, wait time, "cut limit" ? + // XXX what about resume, wait time, "cut limit", sleep time ? return CUPS_BACKEND_OK; } diff --git a/backend_mitsup95d.c b/backend_mitsup95d.c index 5ac38bf..e1abf02 100644 --- a/backend_mitsup95d.c +++ b/backend_mitsup95d.c @@ -320,7 +320,7 @@ top: } } else if (ptr == job->ftr) { - /* XXX Update unknown header field to match sniffs */ + /* Update unknown header field to match sniffs */ if (ctx->type == P_MITSU_P95D) { if (job->hdr1[18] == 0x00) job->hdr1[18] = 0x01;