slp/selphy_print
1
0
Fork 0
Code Issues 51 Pull requests Activity

all: Add some print quantity range checks where we can.

Browse source 
Most backends don't verify against remaining media though.
This commit is contained in:
Solomon Peachy 2015-08-20 23:22:35 -04:00
parent 175f6a52d8
commit cc87cd1cc3
8 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
backend_citizencw01.c
View file

@ -445,7 +445,8 @@ top:
free(resp);
resp = NULL;
/* Set print quantity */
/* Set print quantity */ // XXX check against remaining print count
cw01_build_cmd(&cmd, "CNTRL", "QTY", 8);
snprintf(buf, sizeof(buf), "%07d\r", copies);
ret = cw01_do_cmd(ctx, &cmd, (uint8_t*) buf, 8);

2
backend_dnpds40.c
View file

@ -795,6 +795,8 @@ static int dnpds40_main_loop(void *vctx, int copies) {
return CUPS_BACKEND_FAILED;
/* Update quantity offset with count */
// XXX this breaks if ctx->manual_copies is set, but the job
// has a CNTRL QTY != 1
if (!ctx->manual_copies && copies > 1) {
snprintf(buf, sizeof(buf), "%07d\r", copies);
if (ctx->qty_offset) {

2
backend_kodak605.c
View file

@ -299,6 +299,8 @@ static int kodak605_main_loop(void *vctx, int copies) {
return CUPS_BACKEND_FAILED;
/* Printer handles generating copies.. */
if (copies > 255)
copies = 255;
if (ctx->hdr.copies < copies)
ctx->hdr.copies = copies;

2
backend_kodak6800.c
View file

@ -757,6 +757,8 @@ static int kodak6800_main_loop(void *vctx, int copies) {
return CUPS_BACKEND_FAILED;
/* Printer handles generating copies.. */
if (copies > 255) // XXX test against remaining media?
copies = 255;
if (ctx->hdr.copies < copies)
ctx->hdr.copies = copies;

4
backend_shinkos1245.c
View file

@ -1436,6 +1436,10 @@ static int shinkos1245_main_loop(void *vctx, int copies) {
return CUPS_BACKEND_HOLD;
}
/* Fix max print count. */
if (copies > 9999) // XXX test against remaining media
copies = 9999;
top:
if (state != last_state) {
if (dyesub_debug)

4
backend_shinkos2145.c
View file

@ -1573,7 +1573,9 @@ static int shinkos2145_main_loop(void *vctx, int copies) {
return CUPS_BACKEND_HOLD;
}
top:
// XXX check copies against remaining media!
top:
if (state != last_state) {
if (dyesub_debug)
DEBUG("last_state %d new %d\n", last_state, state);

2
backend_shinkos6145.c
View file

@ -1762,6 +1762,8 @@ static int shinkos6145_main_loop(void *vctx, int copies) {
return CUPS_BACKEND_HOLD;
}
// XXX check copies against remaining media!
top:
if (state != last_state) {
if (dyesub_debug)

2
backend_shinkos6245.c
View file

@ -1679,6 +1679,8 @@ static int shinkos6245_main_loop(void *vctx, int copies) {
goto printer_error;
}
// XXX check copies against remaining media!
top:
if (state != last_state) {
if (dyesub_debug)